Update to latest Nx #311
Merged
Update to latest Nx #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
commented
Nov 16, 2024
| while {final_samples, key, rejects, i = Nx.s64(0)}, i < elem(shape, 0) do | ||
| {samples, key} = Nx.Random.randint(key, 0, opts[:maxval], shape: {elem(shape, 1)}) | ||
| while {final_samples, key, rejects, i = Nx.u32(0)}, i < elem(shape, 0) do | ||
| # TODO: See if we can relax the samples to u32 |
There was a problem hiding this comment.
@msluszniak I kept the type here as s64 because if we change the type, we change the samples, which changes the result of the tests. Can you please tell me if you copied the tests from Python's trimap? Because if not, it is ok for us to change the values here and then update the tests. :)
|
I will merge this. If you folks have feedback, I will tackle them later. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nx defaults to 32 precision everywhere, hence the changes.
Closes #310.